potiuk commented on code in PR #55154:
URL: https://github.com/apache/airflow/pull/55154#discussion_r2314613951
##########
dev/i18n/check_translations_completeness.py:
##########
@@ -124,12 +124,7 @@ def expand_plural_keys(keys: set[str], lang: str) ->
set[str]:
def get_locale_files() -> list[LocaleFiles]:
return [
LocaleFiles(
- locale=locale_dir.name,
- files=[
- f.name
- for f in locale_dir.iterdir()
- if f.suffix == ".json" and f.name != "_freeze_exemptions.json"
- ],
Review Comment:
I see the point yeah.
I think it's really a question of workflow we want to have and I think we
should agree the workflow first :).
My assumption so far:
I thought what we wanted not to stpp those translations of exemptions to
happen even if there is a freeze. I assumed that "freeze" is more for the
"changes" but not "translations" - generallt speaking we want the translations
to continue in the freeze period - even for thosoe "_freeze_exemptions.json".
So effectively we actually (or so I tought) - want to make protection that
we do not add new translations in EN (except specific cases where we
deliberately agree it's needed). But if we **do** agree on a new translation,
then actually (at least IMHO) means that everyone elses target should "move" to
include those new translations. This can be achieved - for example - by making
sure that whenever we agree to add those new translation, we inform all the
translators that there are those new entries (and change the targets - changing
targets should be considered as one of the effects of adding new translations)..
I am afraid that if we add those _exemptions and we will **not** let
translators know that they appeared (and if we do not get them the tool to
translate them) - almost by definition, they will not get translated :) ..
But ... maybe we can use another workflows as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
