jscheffl commented on code in PR #54994:
URL: https://github.com/apache/airflow/pull/54994#discussion_r2319151992
##########
providers/edge3/src/airflow/providers/edge3/plugins/www/src/pages/JobsPage.tsx:
##########
@@ -22,12 +22,17 @@ import { useUiServiceJobs } from "openapi/queries";
import { ErrorAlert } from "src/components/ErrorAlert";
export const JobsPage = () => {
- const { data, error } = useUiServiceJobs();
+ // Note: might use this in future but core-ui-API is not yet bound:
+ // const autoRefreshInterval = useConfig("auto_refresh_interval") as number
| undefined;
Review Comment:
Will have this some potential improvement for the future.
Main question that I have is if we build some "common components" in core
that might be used (via npm?) would this include Core API as well? Would make
life easier. Else I'd prefer to leverage axios but then I would need to build a
LOT of APIs just to consume config entries... and UI API is declared as non
stable anyway... so core UI and plugin API needs some thoughts on JS level...
##########
providers/edge3/src/airflow/providers/edge3/plugins/www/src/pages/JobsPage.tsx:
##########
@@ -22,12 +22,17 @@ import { useUiServiceJobs } from "openapi/queries";
import { ErrorAlert } from "src/components/ErrorAlert";
export const JobsPage = () => {
- const { data, error } = useUiServiceJobs();
+ // Note: might use this in future but core-ui-API is not yet bound:
+ // const autoRefreshInterval = useConfig("auto_refresh_interval") as number
| undefined;
+ const autoRefreshInterval = 5000;
Review Comment:
Good point! adjusted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
