potiuk commented on PR #55154:
URL: https://github.com/apache/airflow/pull/55154#issuecomment-3251222679
Also just to illustrate my point: I rebased my change on top of main and
fixed the remaining TODO. And you can already see how brittle the
"_freeze_exemptions" is and how it blocks things from being fixed.
there were three things added to _freeze_exemptions:
```json
"hitl": {
"requiredActionCount_one": "Required Action ({{count}})",
"requiredActionCount_other": "Required Actions ({{count}})",
"state": {
"noResponseReceived": "No Response Received"
}
},
```
But if you look closer, `requiredActionCount_one` ,
`requiredActionCount_other` - were also added to en/hitl.json (but
noResponseReceived was not). So that's already somewhat a discrepancy. And if
you can look at my PR https://github.com/apache/airflow/pull/55234 where I am
closing the gap. The translation for "requiredActionCount" is added - because
it was also added to `en` translation, but I do not have "noResponseReceived".
So as translator I basically ENOCARE whether I am workign towards a moving
target or not - what I care about is that when I run the translation tool, I
translate **everything missing**.
Also I **think** freeze_exemptions adds quite some complexity. We simply -
for example - do not need the "hitl:" prefix - we referred in a few places with
the the `hitl:` because we had to also add "_freeze_examptions" to
"useTranslate" - but if we get rid of it, we can simplify those almost
everywhere (except the menu).
BTW. I also found one missing "dags:" prefix and unused "common" in
useTranslations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
