shahar1 commented on PR #55154: URL: https://github.com/apache/airflow/pull/55154#issuecomment-3258037032
> But if you look closer, `requiredActionCount_one` , `requiredActionCount_other` - were also added to en/hitl.json (but noResponseReceived was not). Adding these terms should have triggered the pre-commit and fail the PR that added them - it didn't happened since the specific PR that added these terms was merged without rebasing from `main` :) After some rethinking - maybe the current freeze concept is indeed too strict and complex to handle. Maybe instead we could adjust the `check_translations_completeness` to compare the **existing keys**\*, between the current state of main and when the freeze starts (=specified by commit SHA). That way we'll be able to have constant way of measuring completeness before release, while allowing making additions/modifications where needed. \* - We will have to ask avoiding removal of existing keys during this freeze, because then it could change the calculation...but I think it's the least worst. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
