amoghrajesh opened a new pull request, #55767:
URL: https://github.com/apache/airflow/pull/55767
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
## Problem
When tasks are killed by system signals (SIGKILL for OOM, SIGTERM for worker
restarts), they immediately go to FAILED state instead of respecting the task
retries set and going to UP_FOR_RETRY state. This creates unexpected behavior
where exception based failures respect retries but signal based failures don't.
## Root Cause
The supervisor's `final_state` property only checked the exit code and
didn't consider retry eligibility for signal based failures. While exception
based failures properly checked `should_retry` which is set by the API server
when a task is run for the first time a.k.a, in its run context, signal based
failures ignored this logic entirely.
## Testing
DAG used:
```
from airflow import DAG
from datetime import datetime
from airflow.providers.standard.operators.python import PythonOperator
def func():
a = "asd"
while True:
a += a*100000
with DAG(
dag_id="oom_example",
start_date=datetime(2024, 1, 1),
schedule=None,
catchup=False,
doc_md=__doc__,
tags=["oom"],
) as dag:
hello_task = PythonOperator(
task_id="oom_task",
python_callable=func,
retries=3
)
```
### Earlier:
The dag immediately moved into FAILED state without any retries;
<img width="2473" height="839" alt="image"
src="https://github.com/user-attachments/assets/9252747e-be20-4254-8aab-bd792e921b07";
/>
### After:
The dag moves into up for retry state as appropriate:
<img width="1726" height="872" alt="image"
src="https://github.com/user-attachments/assets/f764c658-4839-4d0f-9a12-38035ed9e18e";
/>
See retries:
<img width="1726" height="872" alt="image"
src="https://github.com/user-attachments/assets/082c93a7-e389-41e3-b40e-995427edb271";
/>
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
