ashb commented on code in PR #55767:
URL: https://github.com/apache/airflow/pull/55767#discussion_r2355346941
##########
task-sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -1147,8 +1151,22 @@ def final_state(self):
return self._terminal_state or TaskInstanceState.SUCCESS
if self._exit_code != 0 and self._terminal_state == SERVER_TERMINATED:
return SERVER_TERMINATED
+
+ if self._exit_code != 0 and self._is_signal_retryable() and
self._should_retry:
Review Comment:
```suggestion
if self._is_signal_retryable() and self._should_retry:
```
We already know the exit code is not 0 from the first condition of this fn
on L1150.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
