ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected
trigger rule dep check per dag run
URL: https://github.com/apache/airflow/pull/4751#discussion_r346967221
##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -695,6 +695,7 @@ def _process_task_instances(self, dag,
task_instances_list, session=None):
# update the state of the previously active dag runs
dag_runs = DagRun.find(dag_id=dag.dag_id, state=State.RUNNING,
session=session)
active_dag_runs = []
+ dag_run_finished_ti_map = {}
Review comment:
I don't think we need to store this collection - it doesn't seem we look at
this again, so the existing `finished_task` being inside the per-dagrun loop is
enough?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
