ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected
trigger rule dep check per dag run
URL: https://github.com/apache/airflow/pull/4751#discussion_r344830363
##########
File path: airflow/utils/state.py
##########
@@ -99,6 +99,7 @@ def finished(cls):
cls.SUCCESS,
cls.FAILED,
cls.SKIPPED,
+ cls.UPSTREAM_FAILED
Review comment:
The doc for this list says:
> A list of states indicating that a task started and completed a
> run attempt.
Tasks in upstream_failed fail at the first hurdle: they have never been
started.
Regardless of wether this change is right in the long run if falls way
outside the title of the PR of "collect trigger rule dep check per dag run" to
a behaviour change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
