Nataneljpwd commented on PR #55797: URL: https://github.com/apache/airflow/pull/55797#issuecomment-3341704076
@o-nikolas > Why not just change state here instead of creating a new set and looping over them elsewhere? As then we are spreading logic of updating the tasks state across multiple methods, while now it is all done in the same place, after some thought, I decided that introducing a new variable will make the code easier to follow and less complex, even though there is a new variable, than if we start moving logic around, doing it inline would also require the method name to change, though it is a minor issue with a modern ide. If you do not agree with it, I will make it there inline, even though I think it will introduce more complexity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
