jason810496 commented on code in PR #56150:
URL: https://github.com/apache/airflow/pull/56150#discussion_r2401121246
##########
airflow-core/docs/administration-and-deployment/logging-monitoring/metrics.rst:
##########
@@ -69,11 +69,48 @@ Add the following lines to your configuration file e.g.
``airflow.cfg``
[metrics]
otel_on = True
- otel_host = localhost
- otel_port = 8889
otel_prefix = airflow
- otel_interval_milliseconds = 30000 # The interval between exports,
defaults to 60000
- otel_ssl_active = False
+
+Configure the SDK, by exporting the regular OpenTelemetry variables to your
environment
Review Comment:
Just in case someone might refer "SDK" as "TaskSDK" here.
```suggestion
Configure the OpenTelemetry SDK, by exporting the regular OpenTelemetry
variables to your environment
```
##########
airflow-core/docs/administration-and-deployment/logging-monitoring/traces.rst:
##########
@@ -37,12 +37,44 @@ Add the following lines to your configuration file e.g.
``airflow.cfg``
[traces]
otel_on = True
- otel_host = localhost
- otel_port = 8889
- otel_application = airflow
- otel_ssl_active = False
otel_task_log_event = True
+Configure the SDK, by exporting the regular OpenTelemetry variables to your
environment
Review Comment:
```suggestion
Configure the OpenTelemetry SDK, by exporting the regular OpenTelemetry
variables to your environment
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
