xBis7 commented on PR #56150: URL: https://github.com/apache/airflow/pull/56150#issuecomment-3341736316
@jason810496 Thank you for the review! > Would it be better to retain the compatibility layer for Airflow-Otel environment variables and configuration, while also raising a deprecation warning? Sure, I'll do that. The code of this patch does a validation on the provided configs. I think priorities should be 1. Airflow configs 2. OTel env variables If the Airflow configs are empty, then it will load the OTel env vars and do the validation. In the future, we will just remove the 1st step and it will go straight to loading the env vars. The Airflow configs have a fallback value. As a result, they will never be empty and the env vars won't be checked. I think the default should be `-`. That way we can check if the user added a value or not. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
