ferruzzi commented on code in PR #56326:
URL: https://github.com/apache/airflow/pull/56326#discussion_r2430040907
##########
dev/breeze/tests/test_selective_checks.py:
##########
@@ -719,14 +719,17 @@ def assert_outputs_are_printed(expected_outputs:
dict[str, str], stderr: str):
"test_types": "Providers[amazon]
Providers[apache.livy]",
},
{
- "description": "dbt.cloud...dingding",
- "test_types": "Providers[dbt.cloud]
Providers[dingding]",
+ "description": "atlassian.jir...dbt.cloud",
Review Comment:
Is `atlassian.jir` intentional or a typo missing the `a` at the end?
##########
providers/atlassian/jira/src/airflow/providers/atlassian/jira/hooks/jira.py:
##########
@@ -15,34 +15,59 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-"""Hook for JIRA."""
+"""
+Hook for JIRA.
+
+.. spelling:word-list::
+
+ ClientResponse
+ aiohttp
+ reqrep
Review Comment:
I had no idea we could do this! That's super handy, I've been adding tot he
main list as needed.
##########
providers/atlassian/jira/src/airflow/providers/atlassian/jira/notifications/jira.py:
##########
@@ -61,17 +73,40 @@ def __init__(
@cached_property
def hook(self) -> JiraHook:
- return JiraHook(jira_conn_id=self.jira_conn_id, proxies=self.proxies)
+ return JiraHook(
+ jira_conn_id=self.jira_conn_id,
+ proxies=self.proxies,
+ api_version=self.api_version,
+ api_root=self.api_root,
+ )
- def notify(self, context) -> None:
- fields = dict(
- description=self.description,
- summary=self.summary,
- project=dict(id=self.project_id),
- issuetype=dict(id=self.issue_type_id),
- labels=self.labels,
+ @cached_property
+ def hook_async(self) -> JiraAsyncHook:
Review Comment:
Can you rename this to `async_hook` to match existing examples, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
