potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle
Executors class to avoid cyclic imports
URL: https://github.com/apache/airflow/pull/6596#discussion_r347384080
##########
File path: airflow/executors/__init__.py
##########
@@ -57,31 +56,25 @@ def get_default_executor():
return DEFAULT_EXECUTOR
-class Executors:
Review comment:
The main reason is that we have some logic in the __init__. I wanted to make
sure that wherever we are using import executors just to get the names of the
executors we are not pulling in other dependencies. However after putting the
imports to be local I might actually bring it back to __init__. I understand
the concerns of a file per class and the micro-performance optimisation we can
get.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
