potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle
Executors class to avoid cyclic imports
URL: https://github.com/apache/airflow/pull/6596#discussion_r351280886
##########
File path: airflow/models/dagbag.py
##########
@@ -317,9 +317,7 @@ def kill_zombies(self, zombies, session=None):
had a heartbeat for too long, in the current DagBag.
:param zombies: zombie task instances to kill.
- :type zombies: airflow.utils.dag_processing.SimpleTaskInstance
:param session: DB session.
- :type session: sqlalchemy.orm.session.Session
Review comment:
Same here. I tried to get DagBag typed, and I will do it, just not in this
PR. I just want to get it out and have executors sorted out in this one and
nothing else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
