uranusjr commented on code in PR #56660:
URL: https://github.com/apache/airflow/pull/56660#discussion_r2435214777


##########
airflow-core/src/airflow/api_fastapi/execution_api/datamodels/taskinstance.py:
##########
@@ -247,7 +247,7 @@ class TaskInstance(BaseModel):
     dag_id: str
     run_id: str
     try_number: int
-    dag_version_id: uuid.UUID
+    dag_version_id: uuid.UUID | None = None

Review Comment:
   ```suggestion
       dag_version_id: uuid.UUID | None
   ```
   
   I feel we don’t really need the default, but can just explicitly provide 
None when needed. Also it’d be a good idea to document somewhere (a comment?) 
when None is expected.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to