ephraimbuddy commented on code in PR #56660:
URL: https://github.com/apache/airflow/pull/56660#discussion_r2435476809


##########
airflow-core/src/airflow/api_fastapi/execution_api/datamodels/taskinstance.py:
##########
@@ -247,7 +247,7 @@ class TaskInstance(BaseModel):
     dag_id: str
     run_id: str
     try_number: int
-    dag_version_id: uuid.UUID
+    dag_version_id: uuid.UUID | None = None

Review Comment:
   The TI.dag_version_id is nullable. We only enforce TI.dag_version_id on the 
constructor which can still create a TI even when the value of dag_version_id 
is null. So I think we don't need comment for this. However, let me know again 
if we should and I will add it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to