amoghrajesh commented on code in PR #56503: URL: https://github.com/apache/airflow/pull/56503#discussion_r2417361858
########## providers/amazon/src/airflow/providers/amazon/aws/operators/bedrock.py: ########## @@ -41,8 +41,8 @@ ) from airflow.providers.amazon.aws.utils import validate_execute_complete_event from airflow.providers.amazon.aws.utils.mixins import aws_template_fields +from airflow.sdk.timezone import utcnow Review Comment: This isn't correct. It will break compatibility of this operator to work with Airflow 2 (Airflow 3 has "sdk" but < 3 doesn't), the right way to do with would be is to support compat for Airflow 2, check this one for example: https://github.com/apache/airflow/blob/fcc28a56437c58bc34fea19bd53936c9fdf8799b/providers/amazon/tests/unit/amazon/aws/log/test_s3_task_handler.py#L42-L45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
