dheerajturaga commented on code in PR #56202:
URL: https://github.com/apache/airflow/pull/56202#discussion_r2388411383
##########
airflow-core/src/airflow/models/taskinstance.py:
##########
@@ -945,9 +945,12 @@ def next_retry_datetime(self):
For exponential backoff, retry_delay is used as base and will be
converted to seconds.
"""
- from airflow.sdk.definitions._internal.abstractoperator import
MAX_RETRY_DELAY
+ from airflow.sdk.definitions._internal.abstractoperator import
DEFAULT_RETRY_DELAY, MAX_RETRY_DELAY
delay = self.task.retry_delay
+ if delay is None:
+ # If retry_delay is None, use the default delay
+ delay = DEFAULT_RETRY_DELAY
Review Comment:
@kaxil , Your suggestion doesn't let me past `check-schema-defaults`
```
❌ Found discrepancies between schema and server defaults:
• Field 'retry_delay': schema default is 300, server default is
datetime.timedelta(seconds=300)
To fix these issues:
1. Update airflow-core/src/airflow/serialization/schema.json to match
server defaults, OR
2. Update airflow-core/src/airflow/serialization/serialized_objects.py
class/init defaults to match schema
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
