dheerajturaga commented on code in PR #56202:
URL: https://github.com/apache/airflow/pull/56202#discussion_r2388251767
##########
airflow-core/src/airflow/models/taskinstance.py:
##########
@@ -945,9 +945,12 @@ def next_retry_datetime(self):
For exponential backoff, retry_delay is used as base and will be
converted to seconds.
"""
- from airflow.sdk.definitions._internal.abstractoperator import
MAX_RETRY_DELAY
+ from airflow.sdk.definitions._internal.abstractoperator import
DEFAULT_RETRY_DELAY, MAX_RETRY_DELAY
delay = self.task.retry_delay
+ if delay is None:
+ # If retry_delay is None, use the default delay
+ delay = DEFAULT_RETRY_DELAY
Review Comment:
I haven't really changed any of these values from defaults in my
installation `default_task_retry_delay = 300
max_task_retry_delay = 86400` . Im trying to reproduce with `breeze
start-airflow -e --airflow_version=3.0.6` run a few dags and bring it down
while dags are running and start breeze with 3.1.0 but I was not able to
reproduce this
Let me update this asper your suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
