RoyLee1224 commented on code in PR #55735:
URL: https://github.com/apache/airflow/pull/55735#discussion_r2376544181
##########
airflow-core/src/airflow/ui/src/constants/filterConfigs.tsx:
##########
@@ -61,6 +79,31 @@ export const useFilterConfigs = () => {
label: translate("common:dagId"),
type: FilterTypes.TEXT,
},
+ [SearchParamsKeys.DAG_ID_PATTERN]: {
+ hotkeyDisabled: true,
+ icon: <DagIcon />,
+ label: translate("common:dagId"),
+ type: FilterTypes.TEXT,
+ },
+ [SearchParamsKeys.DAG_VERSION]: {
+ hotkeyDisabled: true,
+ icon: <MdHistory />,
+ label: translate("common:dagRun.dagVersions"),
+ min: 1,
+ type: FilterTypes.NUMBER,
+ },
+ [SearchParamsKeys.DURATION_GTE]: {
+ icon: <MdHourglassEmpty />,
+ label: translate("common:filters.durationFrom", "Duration From"), // To
do: add translation key and remove default value
Review Comment:
Actually, I'd like to propose we hold off on adding specific translation
keys for "Duration From" and "Duration To" for now.
The reason is that I'm developing a `date-selection` component, which will
only use "From" and "To." Adding the keys now would create temporary work for
language owners, as those keys would need to be removed once the new component
is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
