potiuk commented on PR #55917: URL: https://github.com/apache/airflow/pull/55917#issuecomment-3370322203
@jason810496 : > Thanks for the feedback Jarek! If this is the case, I will replace the "CopilotTranslator" class with just a subprocess of "Copilot CLI" and agree, the previous implementation is actually kind of workaround implementation before Copilot CLI released. Yeah. I think that's the most important part - it's simply **way simpler** to get the same result. > IMO, the prompts structure should still be useful even if we want to switch to Copilot CLI, because we could standardize the prompt and customize prompts for each language in a structured way. I am not so sure we need anything else than "translate the TODO: following translations already present". I think we do not have to provide a lot of "manual/per language" context on how to translate each langugage - it's not needed IMHO, simply because AI is pretty good in finding the rules based on the context. Pretty much all the translations we are doing are incremental -based on hundreds of already made translations in the .json files. There are basically two stages: * you do first time translation - you do not yet know the rules you translate it for the first time and the rules are created as you do it, This happens exactly once per language. * you do incremental translation - where you already have 100s of translations done and you want to add few more that were added since last time. This is quite special case where the "solution space" is very limited and task is very simple. To be honest, if we need to add any more context and prompt in this case than "follow translations already done", this means that AI is not doing it's job well - it should figure out all the rules that were already applied on it's own and apply it well. This is **precisely** what AI models are supposed to do. They excel in it. But of course maybe it's a good idea for the initial translation to add some prompts like "do it in the way that uses less space e for the UI" etc. , so maybe it makes sense for the first time run (but i am not sure it should be different per language, and that people who will add languages will know what to add their "per language" prompt. But this can also be done interactivel in the first translation - simply because once we translate several few hundreds of those translations, AI should learn from the context and pick up the style and approach from those already translated messages without the need of the additional contest. Or so I think at least :) @shahar1 > I did quite well with opening the English translation side by side the Hebrew/Arabic one, and translate line-by-line, like this: One potential issue I see with it, is that while it's fine for bulk translation, it's not really good for incremental translations - especially when we skip the "TODO:" phase. What you compare then when you compare two files en + target language are two files with completed translations, but you don't see what has changed really when you look at those two different files. Simply you have to mentally do two comparisions: * find which translations were addded (easy to do when you compare changed file with previous version) * compare those new translations with english ones I don't think that the current IDEs or manual can help with easily doing both comparisions at the same time. And the copilot interactive "accept" view does this exactly - it shows you what changed, what was the english phrase (with TODO:) and allows you to single click - approve/reject (or even correct it) - and move to the next change. note that often each incremental change will contain several changes Just to simmarize it - I am not against doing it but I doubt it will make things easier :). But maybe it's just me - we can always add this option to auto-translate and ask translators if this is good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
