Re: [PR] Integrate Copilot for Automated Language Translation [airflow]

[via GitHub]

shahar1 commented on PR #55917:
URL: https://github.com/apache/airflow/pull/55917#issuecomment-3367197469

   > This PR is a bit too complex and makes (IMHO) the usability of copilot 
translation a bit less than the one embedded in IDEs / with interactivity. I am 
not sure if we want to do it - this might - paradoxically - make the 
translations less good because people will be too "lazy" to review them and it 
will not be as easy to review as with interactive copilot sessions.
   >
   > I think the biggest value of the IDE-driven translation is the UI/UX where 
you see together the original (with TODO) and translation and you can 
individually approve blocks of translation or even modify them directly in the 
editor. This is why running "please translate all todo: phrases" in IntelliJ or 
VSCode integrated copilot is so nice, because you get HITL (Human-In-The-Loop) 
where you can review and look at the translations individually after they are 
done. This automated translation here has the drawback, that when you run 
automated translation like that and even try to review it in the commit, you do 
not see original English text.
   > 
   > This is what you see when you do translations in IntelliJ's copilot:
   > 
   > <img alt="Screenshot 2025-10-03 at 02 24 52" width="1427" height="1140" 
src="https://private-user-images.githubusercontent.com/595491/497059665-4e1f7cc0-a366-45ac-b11c-662661b8d11a.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTk1MjI4ODksIm5iZiI6MTc1OTUyMjU4OSwicGF0aCI6Ii81OTU0OTEvNDk3MDU5NjY1LTRlMWY3Y2MwLWEzNjYtNDVhYy1iMTFjLTY2MjY2MWI4ZDExYS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUxMDAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MTAwM1QyMDE2MjlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kMTYzZDU4NTM0NTM3NmFiYTlhYzQ5ZTJlNjczMjEwYmIyYzZjMWJiNTRhNzA2YTExOTQ5MTIwYTRjYjdkZjhkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.WgUYoCh348_8xUBwsYrVpZ58U2gBuu-MmfakMmW0aLU";>
   > I can individually review before/after as well as even manually modify the 
translations. And it's really good UX.
   > 
   I understand your concerns regarding the complexity of the PR in its current 
state, and I'm sure that Jason will do his best to simplify it. However, 
regarding the latter statement - eventually the responsibility for reviewing is 
of the Translation Owners (or, if it's their own PR - their translation peers) 
- so even if the entire PR was made by running a single CLI command, we do 
expect the reviewer(s) to approve the quality of each and every term in the 
translation (they could use tooling for that as well). Of course, after running 
the command, the author should do it as well - but I don't think that we need 
to limit them only to the method that you suggested. From my personal 
experience (even before introducing the `--add-missing`), I did quite well with 
opening the English translation side by side the Hebrew/Arabic one, and 
translate line-by-line, like this:
   <img width="1921" height="205" alt="image" 
src="https://github.com/user-attachments/assets/172ea96c-5deb-4730-b362-ba3f79d870b9";
 />
   Working with Copilot plugin has it perks, but I have to say that it's often 
quite buggy - so mileage might differ regarding UX.
   
   > I think there is a case where we want to translate "all languages" - when 
we want to open single PR for all translators (I tried it before the release) - 
but I think this should be reserved only for "all languages" not for single 
language (there interactive approach is way better).
   
   Agree about this one, although we need to think about improving the 
reviewing process in these cases*. For now it would be nice to have this 
ability as part of the script.
   
   
   \* -  the more translations we have, we'll more reviewers in the same PR - 
it might create a bottleneck (reviewers' availability/GitHub limitations for 
max. num of reviewers)...but that's for another thread :)
   
   > And even if we want to do it automatically - all the token/etc. is not 
needed. Recently GitHub released "copilot" cli, I tested it and it works very 
well. In interactive mode it can even provide similar green/red display in the 
terminal (without capability of correcting it manually yet - but this is likely 
something they will add). It's just enough to start copilot CLI with subprocess 
and it will do all the gh token handling thing.
   > 
   > ```
   > copilot --allow-all-tools --add-dir . -p 'Please translate the remaining 
"TODO: translate" in airflow-core/src/airflow/ui/public/i18n/locales/pl/'
   > ```
   > 
   It would be great to give this one a shot! (what are the odds that we'll 
also be able to use it in the CI at some point?)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org