vincbeck commented on issue #55955: URL: https://github.com/apache/airflow/issues/55955#issuecomment-3334247066
> I think it would better to separate to 2 releases. > > 1. Add Firehouse Hook ( by just import from existed Kinesis Hook ) and add deprecation warning to Kinesis Hook that user should switch to Firehouse Hook. > 2. After 1. is released, then replace Kinesis Hook implementation with "Kinesis Data Stream" > > cc [@eladkal](https://github.com/eladkal) > > Any comment for this approach? Yes and no :) I agree with 1. but I disagree with 2. Doing 2 would means creating a major version for Amazon provider package, but even more importantly having a very short deprecation period for users. We cannot do that. I think we should: - Do 1 as suggested by @jason810496 - Create Kinesis hook either in `providers/amazon/src/airflow/providers/amazon/aws/hooks/kinesis.py` or `providers/amazon/src/airflow/providers/amazon/aws/hooks/kinesis_analytics.py` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
