ashb commented on code in PR #56976:
URL: https://github.com/apache/airflow/pull/56976#discussion_r2449396570
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/triggers/pod.py:
##########
@@ -183,6 +188,11 @@ async def run(self) -> AsyncIterator[TriggerEvent]:
)
return
except Exception as e:
+ self.log.exception(
Review Comment:
Do we need this one to? Spent the resumed normal operator already log it too
from the info in the event?
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/triggers/pod.py:
##########
@@ -143,7 +143,12 @@ def serialize(self) -> tuple[str, dict[str, Any]]:
async def run(self) -> AsyncIterator[TriggerEvent]:
"""Get current pod status and yield a TriggerEvent."""
- self.log.info("Checking pod %r in namespace %r.", self.pod_name,
self.pod_namespace)
+ self.log.info(
+ "Checking pod %r in namespace %r.",
+ self.pod_name,
+ self.pod_namespace,
+ poll_interval=self.poll_interval,
Review Comment:
I think this might not work on Airflow 2 as we don't use structlog there yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
