potiuk commented on code in PR #56700:
URL: https://github.com/apache/airflow/pull/56700#discussion_r2451623855
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -89,131 +95,6 @@ class PodPhase:
terminal_states = {FAILED, SUCCEEDED}
-class PodOperatorHookProtocol(Protocol):
Review Comment:
I think this question is not the one that should be asked - hence I
answered the righ one. I don't think we ever specified what is and what is not
public API.
But generally it's pretty much the same - Breaking = Public API change in a
breaking way. I have not found it to be used elsewhere in our code except
cncf.kubernetes - so I assume the intention was to not be used outside of it ->
hence not breaking -> hence no public API.
BTW, Semver is not about whether something is a public API or not (because
often it is not clearly specified) - but about whether intention of it was to
be used as such.
So actually the **proper** question (if we want to be picky and ask really
good question) to ask is "was that intended to be used outside of the provider
and changes it in a breaking way?" , And my answer is "I don't think so".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
