jscheffl commented on code in PR #56700:
URL: https://github.com/apache/airflow/pull/56700#discussion_r2452753296
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -89,131 +95,6 @@ class PodPhase:
terminal_states = {FAILED, SUCCEEDED}
-class PodOperatorHookProtocol(Protocol):
Review Comment:
Sorry was distracted all day.
Technically it was not decleared private but I agree to Jarek that we did
not define the "public API" on providers. Had the same question if this is
breaking as well and did not find any other reference in "our" codebose.
The Protocol is not documented elsewhere and is not needed if you implement
operators/Dags or so. So a "normal user" should not see this being removed. I
assume every "Advanced user" that potentially builds around the package and
extends the operators and needs this would know how to adjust but would be a
very nice use case/extension. As GKE was also not using it I think it is safe
to remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
