amoghrajesh commented on PR #56762: URL: https://github.com/apache/airflow/pull/56762#issuecomment-3432371355
> LGTM overall — clear improvement and simpler deps. > > I did not understand completely why we removed 429 retry logic. Earlier (per the PR description and early commits), the Task SDK’s retry logic used to respect Retry-After headers from 429 responses - pausing before retrying. > > In the final version, the `_should_retry_api_request` predicate only retries on: > > * `httpx.RequestError` (network / timeout) > * `httpx.HTTPStatusError` with status ≥ 500 > > It no longer retries on 429, nor does it read Retry-After. Why? Thanks @sunank200, the reason for that is simple -- API server doesn't have feature support for rate limiting! So it doesnt make sense to have the client support it when server doesn't: https://github.com/apache/airflow/pull/56762#discussion_r2440083758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
