amoghrajesh commented on code in PR #56762:
URL: https://github.com/apache/airflow/pull/56762#discussion_r2452111586
##########
task-sdk/src/airflow/sdk/api/client.py:
##########
@@ -812,6 +817,14 @@ def noop_handler(request: httpx.Request) -> httpx.Response:
API_SSL_CERT_PATH = conf.get("api", "ssl_cert")
+def _should_retry_api_request(exception: BaseException) -> bool:
+ """Determine if an API request should be retried based on the exception
type."""
Review Comment:
> Consider adding a brief comment in _should_retry_api_request about why
429s aren’t retried anymore.
No need, it never worked :), that comment would only mislead.
> Nits: Update PR description to match the final behaviour (since 429
handling was dropped).
Thanks, that has been updated now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
