odaneau-astro commented on PR #56854: URL: https://github.com/apache/airflow/pull/56854#issuecomment-3433315772
I like the simplicity of this solution. The implementation expands on my original idea in https://playcode.io/2464307 and fixes obvious flaws in my POC. I agree that we do want to expand customization options to other attributes, but we need to brainstorm a little more on what that would include. If we used a JSON env var with a single entry for navbar color for now, it would allow us to expand on it later. Personally, I would not offer users the ability to customize things component-by-component. It would add a maintenance burden for end users when we add new components in the future. I would limit configuration attributes to avoid "config hell". Possibly start with accessibility requirements and corporate branding configs. Here are some that are top of mind: - border width - border radius - background color - default padding - default margin - header font family - body font family - default font size - line height Keep in mind that standardizing our existing codebase to use these will take time and effort. FYI, I also have this draft PR in the works to centralize component tokens and make them rely on more brand colors: https://github.com/apache/airflow/pull/56347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
