odaneau-astro commented on PR #56854: URL: https://github.com/apache/airflow/pull/56854#issuecomment-3433343705
> @odaneau-astro Would love your thoughts on this? > > For me, I was thinking about allowing a larger theme json config element. > > Also I am skeptical about us maintaining how color palettes are generated. I think that should be the domain of the person customizing the theme. We can still point them to useful tools. It also would be a slow development cycle to need to refresh the whole UI when you realize your base color wasn't just right. I don't have a strong opinion on maintaining the palette generation logic ourselves. Users are already familiar with single hex values from Airflow 2 and it simplifies things for end users. But at the same time, there's no escape hatch if the colors don't turn out to be readable. We could very well use @Zinkue's generatePalette.ts logic in the playground (https://github.com/apache/airflow/pull/55789) and output the hex color list. Then, only allow the long list of hex codes for 50-950 values in the JSON config. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
