uranusjr commented on code in PR #57335: URL: https://github.com/apache/airflow/pull/57335#discussion_r2464984314
########## shared/logging/src/airflow_shared/logging/percent_formatter.py: ########## @@ -26,7 +26,7 @@ from typing import TYPE_CHECKING, ClassVar import structlog.dev -from structlog.dev import ConsoleRenderer, Styles +from structlog.dev import ColumnStyles, ConsoleRenderer Review Comment: Let’s move type-hint-only imports into TYPE_CHECKING so future changes break less things. We won’t need to bump structlog version either if we do this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
