uranusjr commented on code in PR #57335: URL: https://github.com/apache/airflow/pull/57335#discussion_r2465053198
########## shared/logging/src/airflow_shared/logging/percent_formatter.py: ########## @@ -26,7 +26,7 @@ from typing import TYPE_CHECKING, ClassVar import structlog.dev -from structlog.dev import ConsoleRenderer, Styles +from structlog.dev import ColumnStyles, ConsoleRenderer Review Comment: Ruff prefers to merge imports, and since ConsoleRenderer is used at runtime, it prefers putting Style/ColumnStyles in the same line, even though that name is not used at runtime. But you still can move it into a type-checking-only block instead as a separate import, and Ruff will allow it since it assumes you have good reasons (as we do here). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
