jscheffl commented on code in PR #57372:
URL: https://github.com/apache/airflow/pull/57372#discussion_r2467090313
##########
providers/edge3/src/airflow/providers/edge3/cli/worker.py:
##########
@@ -176,7 +176,19 @@
return EdgeWorkerState.IDLE
@staticmethod
- def _run_job_via_supervisor(workload) -> int:
+ @cache
+ def _execution_api_server_url() -> str:
+ """Get the execution api server url from config or environment."""
+ api_url = conf.get("edge", "api_url")
+ execution_api_server_url = conf.get("core",
"execution_api_server_url", fallback="")
+ if not execution_api_server_url and api_url:
+ # Derive execution api url from edge api url as fallback
+ execution_api_server_url =
api_url.replace("edge_worker/v1/rpcapi", "execution")
+ logger.info("Using execution api server url: %s",
execution_api_server_url)
Review Comment:
The URL is not containing any sensitive information that is not contained in
the deployment configuration. It is a semi public information. No token or
other secret is added to the URL used here, it is only the base URL.
Secrets and data will be passed in headers and request body, not logged here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
