amoghrajesh commented on code in PR #57372: URL: https://github.com/apache/airflow/pull/57372#discussion_r2468291343
########## providers/edge3/docs/deployment.rst: ########## @@ -51,8 +51,8 @@ Minimum Airflow configuration settings for the Edge Worker to make it running is - Section ``[core]`` - ``execution_api_server_url``: If not set, the base URL from ``edge.api_url`` will be used. For example, - when ``edge.api_url`` is set to ``https://your-hostname-and-port/edge_worker/v1/rpcapi``, it will - default to ``https://your-hostname-and-port/execution/``. + when ``edge.api_url`` is set to ``https://your-hostname-and-port/subpath/edge_worker/v1/rpcapi``, it will + default to ``https://your-hostname-and-port/subpath/execution/`` (starting from version 3.0.0). Review Comment: Good call Elad ########## providers/edge3/docs/deployment.rst: ########## @@ -51,8 +51,8 @@ Minimum Airflow configuration settings for the Edge Worker to make it running is - Section ``[core]`` - ``execution_api_server_url``: If not set, the base URL from ``edge.api_url`` will be used. For example, - when ``edge.api_url`` is set to ``https://your-hostname-and-port/edge_worker/v1/rpcapi``, it will - default to ``https://your-hostname-and-port/execution/``. + when ``edge.api_url`` is set to ``https://your-hostname-and-port/subpath/edge_worker/v1/rpcapi``, it will + default to ``https://your-hostname-and-port/subpath/execution/`` (starting from version 3.0.0). Review Comment: ```suggestion default to ``https://your-hostname-and-port/subpath/execution/`` (starting from version Airflow version 3.0.0). ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
