ferruzzi opened a new pull request, #57464:
URL: https://github.com/apache/airflow/pull/57464
Had a chat with @bbovenzi and @ramitkataria at Summit about what we need to
do to get Deadline Alerts integrated into the UI. The first main part is to
move the DeadlineAlert data out of the serialized_dag and into a new table that
can be accessed directly by the UI, so that's what we're tackling here. This
is a bigger task than I imagined, so I am breaking it into a few parts.
**Changes**:
Part 1: Creates the new deadline_alerts table (and ORM) with fkey reference
to the deadlines that they spawn, and lays out the plan for the data migration
**What's next:**
- Part 2 will focus on the actual data migration with batch processing. The
general plan is laid out in a comment in the migration file
- Part 3 will update application code to use new table structure
**Testing**:
Unit tests for the new ORM where possible with manual testing of the
migration file since we don't generally do automated tests for those.
Qasi-related, I gave up on trying to think of a better name for these tables
but @o-nikolas hit on a great one in a chat earlier today. I am going to
deprecate `DeadlineAlert` as a model/ORM/entity and replace it with
`DeadlineDefinition`. Then when a user defines the `DeadlineDefinition`, a
single instance of the `DeadlineDefinition` is a `Deadline`. That flows much
more logically than saying a `DeadlineAlert` spawns `Deadline`s. But that's
future work.
cc @seanghaeli
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
