vincbeck commented on code in PR #57464: URL: https://github.com/apache/airflow/pull/57464#discussion_r2474335644
########## airflow-core/src/airflow/migrations/versions/0092_3_2_0_ui_improvements_for_deadlines.py: ########## @@ -0,0 +1,113 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +Add required fields to enable UI integrations for the Deadline Alerts feature. + +Revision ID: 55297ae24532 +Revises: b87d2135fa50 +Create Date: 2025-10-17 16:04:55.016272 +""" + +from __future__ import annotations + +import sqlalchemy as sa +from alembic import op +from sqlalchemy_utils import UUIDType + +from airflow.migrations.db_types import TIMESTAMP + +revision = "55297ae24532" +down_revision = "b87d2135fa50" +branch_labels = None +depends_on = None +airflow_version = "3.2.0" + + +def upgrade(): + """Make changes to enable adding DeadlineAlerts to the UI.""" + # TODO: We may finally have come up with a better naming convention. For ease of migration, + # we are going to keep deadline_alert here to match the model's name, but in the near future Review Comment: But you'll do it anyway right? So why not doing it directly? You'll have to create a new migration to rename the DB, if we can avoid that, that'd be great -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
