uranusjr commented on PR #56272: URL: https://github.com/apache/airflow/pull/56272#issuecomment-3459979818
This looks good to me. There’s only one other `notify_dagrun_state_changed` call without arguments (in the same file). I feel we should also add a msg to that call as well, and make `msg` a required argument. An empty string (the current default) is never useful, and we should encourage all calls to provide some information instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
