1fanwang commented on PR #56272: URL: https://github.com/apache/airflow/pull/56272#issuecomment-3471455856
Thanks TP @uranusjr > This looks good to me. There’s only one other notify_dagrun_state_changed call without arguments (in the same file). Addressed in https://github.com/apache/airflow/pull/56272/commits/b90fb39485b5b3ae5246e78eb5df4e2f4ab348ae > I feel we should also add a msg to that call as well, and make msg a required argument. An empty string (the current default) is never useful, and we should encourage all calls to provide some information instead. Addressed in https://github.com/apache/airflow/pull/56272/commits/7bf5b84c8393866c302789f3a2ae549082ee3b02 Also checked and made sure all calls to notify_dagrun_state_changed is passing a meaningful msg now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
