vincbeck commented on code in PR #57373:
URL: https://github.com/apache/airflow/pull/57373#discussion_r2478409737
##########
airflow-core/src/airflow/models/connection.py:
##########
@@ -128,8 +128,8 @@ class Connection(Base, LoggingMixin):
__tablename__ = "connection"
id: Mapped[int] = mapped_column(Integer(), primary_key=True)
- conn_id: Mapped[str] = mapped_column(String(ID_LEN), unique=True,
nullable=False)
- conn_type: Mapped[str] = mapped_column(String(500), nullable=False)
+ conn_id: Mapped[str | None] = mapped_column(String(ID_LEN), unique=True,
nullable=False)
+ conn_type: Mapped[str | None] = mapped_column(String(500), nullable=False)
Review Comment:
Those are not consistent. Should they be nullable? If yes then the type
should be `str | None` and `nullable=True`, if not it should be `str` and
`nullable=False`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
