Dev-iL commented on code in PR #57369:
URL: https://github.com/apache/airflow/pull/57369#discussion_r2478711951


##########
providers/standard/src/airflow/providers/standard/sensors/external_task.py:
##########
@@ -251,17 +252,15 @@ def __init__(
         self.deferrable = deferrable
         self.poll_interval = poll_interval
 
-    def _get_dttm_filter(self, context):
+    def _get_dttm_filter(self, context: Context) -> list[datetime.datetime]:

Review Comment:
   It's always good to consider how the output is used, in case the hint can be 
made a more abstract collection type (e.g. `Container`, `Sequence`, `Iterable`, 
[etc](https://docs.python.org/3.14/library/collections.abc.html#collections-abstract-base-classes)).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to