o-nikolas commented on code in PR #57579:
URL: https://github.com/apache/airflow/pull/57579#discussion_r2479297652
##########
airflow-core/docs/core-concepts/executor/local.rst:
##########
@@ -21,32 +21,29 @@
Local Executor
==============
-:class:`~airflow.executors.local_executor.LocalExecutor` runs tasks by
spawning processes in a controlled fashion in different modes.
+:class:`~airflow.executors.local_executor.LocalExecutor` runs tasks by
spawning processes in a controlled fashion on the scheduler node.
-Given that BaseExecutor has the option to receive a ``parallelism`` parameter
to limit the number of process spawned,
-when this parameter is ``0`` the number of processes that LocalExecutor can
spawn is unlimited.
+The parameter ``parallelism`` limits the number of process spawned not to
overwhelm the node.
+This parameter must be greater than ``0``.
Review Comment:
Base executor init will still allow parallelism to be equal to zero. Which I
suppose you may want, to disable an executor from taking tasks? Not sure I
really think that's a valid use case but the code does allow it, so we should
either change that or update this:
```suggestion
This parameter must be greater than or equal to ``0``.
```
##########
airflow-core/src/airflow/executors/local_executor.py:
##########
@@ -138,7 +138,7 @@ class LocalExecutor(BaseExecutor):
It uses the multiprocessing Python library and queues to parallelize the
execution of tasks.
- :param parallelism: how many parallel processes are run in the executor
+ :param parallelism: how many parallel processes are run in the executor,
must be > 0
Review Comment:
Same as above:
```suggestion
:param parallelism: how many parallel processes are run in the executor,
must be >= 0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
