jscheffl commented on code in PR #52392:
URL: https://github.com/apache/airflow/pull/52392#discussion_r2484904488
##########
chart/values.schema.json:
##########
@@ -5094,6 +5094,53 @@
],
"default": null
},
+ "hpa": {
+ "description": "HPA configuration.",
+ "type": "object",
+ "additionalProperties": false,
+ "properties": {
+ "enabled": {
+ "description": "Allow HPA autoscaling",
+ "type": "boolean",
+ "default": false
+ },
+ "minReplicaCount": {
+ "description": "Minimum number of webservers
created by HPA.",
+ "type": "integer",
+ "default": 1
+ },
+ "maxReplicaCount": {
+ "description": "Maximum number of webservers
created by HPA.",
+ "type": "integer",
+ "default": 5
+ },
+ "metrics": {
+ "description": "Specifications for which to use to
calculate the desired replica count.",
+ "type": "array",
+ "default": [
+ {
+ "type": "Resource",
+ "resource": {
+ "name": "cpu",
+ "target": {
+ "type": "Utilization",
+ "averageUtilization": 80
Review Comment:
In regards of responsiveness and time it needs to run another instance, is
80% somethings to mention as a good default? I would have expected to start
scaling already at 50% to ensure good response times.
Can you share a value from your production that is a sensible default?
##########
chart/values.schema.json:
##########
@@ -5094,6 +5094,53 @@
],
"default": null
},
+ "hpa": {
+ "description": "HPA configuration.",
+ "type": "object",
+ "additionalProperties": false,
+ "properties": {
+ "enabled": {
+ "description": "Allow HPA autoscaling",
Review Comment:
Wording nit.
```suggestion
"description": "Enable HPA autoscaling for API
server",
```
##########
chart/values.schema.json:
##########
@@ -5094,6 +5094,53 @@
],
"default": null
},
+ "hpa": {
+ "description": "HPA configuration.",
+ "type": "object",
+ "additionalProperties": false,
+ "properties": {
+ "enabled": {
+ "description": "Allow HPA autoscaling",
+ "type": "boolean",
+ "default": false
+ },
+ "minReplicaCount": {
+ "description": "Minimum number of webservers
created by HPA.",
Review Comment:
Can you adjust the text in line 5050 as well that replicas are not
considered if HPA is enabled?
##########
chart/values.schema.json:
##########
@@ -5094,6 +5094,53 @@
],
"default": null
},
+ "hpa": {
+ "description": "HPA configuration.",
+ "type": "object",
+ "additionalProperties": false,
+ "properties": {
+ "enabled": {
+ "description": "Allow HPA autoscaling",
+ "type": "boolean",
+ "default": false
+ },
+ "minReplicaCount": {
+ "description": "Minimum number of webservers
created by HPA.",
Review Comment:
```suggestion
"description": "Minimum number of webservers
created by HPA if HPA enabled.",
```
##########
chart/values.schema.json:
##########
@@ -5094,6 +5094,53 @@
],
"default": null
},
+ "hpa": {
+ "description": "HPA configuration.",
Review Comment:
Can you be a bit mor verbose for all knowing what HPA is?
```suggestion
"description": "Horizontal Pod Autoscaler (HPA)
configuration. (optional)",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
