HsiuChuanHsu commented on code in PR #52392:
URL: https://github.com/apache/airflow/pull/52392#discussion_r2486464994
##########
chart/values.schema.json:
##########
@@ -5094,6 +5094,53 @@
],
"default": null
},
+ "hpa": {
+ "description": "HPA configuration.",
Review Comment:
Yeah. It should be more details. Add more description in `apiServer.hpa`
section in `values.yaml`.
##########
chart/values.schema.json:
##########
@@ -5094,6 +5094,53 @@
],
"default": null
},
+ "hpa": {
+ "description": "HPA configuration.",
+ "type": "object",
+ "additionalProperties": false,
+ "properties": {
+ "enabled": {
+ "description": "Allow HPA autoscaling",
Review Comment:
Fixed.
##########
chart/values.schema.json:
##########
@@ -5094,6 +5094,53 @@
],
"default": null
},
+ "hpa": {
+ "description": "HPA configuration.",
+ "type": "object",
+ "additionalProperties": false,
+ "properties": {
+ "enabled": {
+ "description": "Allow HPA autoscaling",
+ "type": "boolean",
+ "default": false
+ },
+ "minReplicaCount": {
+ "description": "Minimum number of webservers
created by HPA.",
Review Comment:
Yes, this one is important for user. Add more description in
`apiServer.replica` section in `values.yaml`.
Also it should be apiServer instead of webservers.
##########
chart/values.schema.json:
##########
@@ -5094,6 +5094,53 @@
],
"default": null
},
+ "hpa": {
+ "description": "HPA configuration.",
+ "type": "object",
+ "additionalProperties": false,
+ "properties": {
+ "enabled": {
+ "description": "Allow HPA autoscaling",
+ "type": "boolean",
+ "default": false
+ },
+ "minReplicaCount": {
+ "description": "Minimum number of webservers
created by HPA.",
+ "type": "integer",
+ "default": 1
+ },
+ "maxReplicaCount": {
+ "description": "Maximum number of webservers
created by HPA.",
+ "type": "integer",
+ "default": 5
+ },
+ "metrics": {
+ "description": "Specifications for which to use to
calculate the desired replica count.",
+ "type": "array",
+ "default": [
+ {
+ "type": "Resource",
+ "resource": {
+ "name": "cpu",
+ "target": {
+ "type": "Utilization",
+ "averageUtilization": 80
Review Comment:
We do most of our autoscling settings on KEDA instead of HPA, but it makes
sense to ensure good response times at 50%.
Updated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
