uranusjr commented on code in PR #57724:
URL: https://github.com/apache/airflow/pull/57724#discussion_r2485986571
##########
airflow-core/tests/unit/ti_deps/deps/test_ready_to_reschedule_dep.py:
##########
@@ -142,11 +142,6 @@ def
test_mapped_task_should_pass_if_ignore_in_reschedule_period_is_set(self, not
dep_context = DepContext(ignore_in_reschedule_period=True)
assert ReadyToRescheduleDep().is_met(ti=ti, dep_context=dep_context)
- def test_mapped_task_should_pass_if_not_reschedule_mode(self,
not_expected_tr_db_call):
- ti = self._get_task_instance(State.UP_FOR_RESCHEDULE, map_index=42)
- del ti.task.reschedule
- assert ReadyToRescheduleDep().is_met(ti=ti)
Review Comment:
From what I can understand, this test is simply incorrect. A mapped task
_should_ have its TaskReschedule checked (see comments in
ready_to_reschedule.py)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
