kacpermuda opened a new pull request, #57809:
URL: https://github.com/apache/airflow/pull/57809
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Currently OpenLineage provider only supports simple parent-child references,
with two gaps:
1. DagRun is always considered a root job for all the tasks
2. DagRun has no parent or root jobs
This PR adds a possibility to provide a DagRun with openlineage parent and
root job/run identifiers so that the parentRunFacet can be created for DagRun
OpenLineage event. This is done by using `DagRun.conf`, the only possibility I
found to pass a complex data structure to a DagRun for both Airflow 2 and 3,
that can be retrieved by using TaskInstance (available for listeners) and also
possible to pass through both API call and TriggerDagRunOperator (will be
instrumented in separate PR to automatically inject OL metadata into conf of
triggered DagRun).
Additionaly, if DagRun has a root job/run, it's propagated to all the tasks
as root job/run, so that it's reflecting the real situation.
This PR is only adding support for this feature in OpenLineage provider, so
that it looks for _openlineage data in dagrun conf and creates parentRunFacet
from it. Other operators like `TriggerDagRunOperator` will be instrumented in
separate PRs so that this data is injected automatically for people using
OpenLineage, improving lineage quality.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
