uranusjr commented on code in PR #57342:
URL: https://github.com/apache/airflow/pull/57342#discussion_r2493093177
##########
airflow-core/src/airflow/ui/src/components/TriggerDag/TriggerDAGForm.tsx:
##########
@@ -123,6 +131,40 @@ const TriggerDAGForm = ({ dagDisplayName, dagId, isPaused,
onClose, open }: Trig
)}
/>
+ <Controller
+ control={control}
+ name="dataIntervalStart"
+ render={({ field }) => (
+ <Field.Root invalid={Boolean(errors.date) || dataIntervalInvalid}
orientation="horizontal">
+ <Stack>
+ <Field.Label fontSize="md" style={{ flexBasis: "30%" }}>
+ {translate("dagRun.dataIntervalStart")}
+ </Field.Label>
+ </Stack>
+ <Stack css={{ flexBasis: "70%" }}>
+ <DateTimeInput {...field} onBlur={resetDateError} size="sm" />
+ </Stack>
+ </Field.Root>
+ )}
+ />
Review Comment:
What happens if the user sets data interval but leaves logical date empty?
Does the API auto-populates it? (If so, we should probably add a hint on UI so
the user doesn’t try too hard filling both in.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
