ashb commented on code in PR #57342:
URL: https://github.com/apache/airflow/pull/57342#discussion_r2493844224
##########
airflow-core/src/airflow/ui/src/components/TriggerDag/TriggerDAGForm.tsx:
##########
@@ -123,6 +131,40 @@ const TriggerDAGForm = ({ dagDisplayName, dagId, isPaused,
onClose, open }: Trig
)}
/>
+ <Controller
+ control={control}
+ name="dataIntervalStart"
+ render={({ field }) => (
+ <Field.Root invalid={Boolean(errors.date) || dataIntervalInvalid}
orientation="horizontal">
+ <Stack>
+ <Field.Label fontSize="md" style={{ flexBasis: "30%" }}>
+ {translate("dagRun.dataIntervalStart")}
+ </Field.Label>
+ </Stack>
+ <Stack css={{ flexBasis: "70%" }}>
+ <DateTimeInput {...field} onBlur={resetDateError} size="sm" />
+ </Stack>
+ </Field.Root>
+ )}
+ />
Review Comment:
> It looks like the model validator will ignore data_interval_start and
data_interval_end if logical_date is None
That should probably change -- they aren't actually tied together in any way
are they? Everything else would work fine with a data interval and None as a
logical date, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
