ferruzzi commented on code in PR #53722:
URL: https://github.com/apache/airflow/pull/53722#discussion_r2495614302
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -651,9 +652,14 @@ def _executable_task_instances_to_queued(self, max_tis:
int, session: Session) -
)
for pool_name, num_starving_tasks in pool_num_starving_tasks.items():
- Stats.gauge(f"pool.starving_tasks.{pool_name}", num_starving_tasks)
- # Same metric with tagging
- Stats.gauge("pool.starving_tasks", num_starving_tasks,
tags={"pool_name": pool_name})
+ # If enabled on the config, publish metrics twice,
+ # once with backward compatible name, and then with tags.
Review Comment:
Just personal preference, but I don't think we need a 2-line comment every
time we emit the metrics. A good docstring in the DualStatsManager should
suffice IMHO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
