xBis7 commented on code in PR #53722:
URL: https://github.com/apache/airflow/pull/53722#discussion_r2497643895
##########
providers/openlineage/src/airflow/providers/openlineage/plugins/adapter.py:
##########
@@ -161,8 +161,16 @@ def emit(self, event: RunEvent):
try:
with ExitStack() as stack:
-
stack.enter_context(Stats.timer(f"ol.emit.attempts.{event_type}.{transport_type}"))
- stack.enter_context(Stats.timer("ol.emit.attempts"))
+ try:
+ from airflow.metrics.dual_stats_manager import
DualStatsManager
+
+ # If enabled on the config, publish metrics twice,
+ # once with backward compatible name, and then with tags.
+
stack.enter_context(DualStatsManager.timer("ol.emit.attempts"))
Review Comment:
*
https://github.com/apache/airflow/pull/53722/commits/043f1408cd2f34c0dc65c1f05454f1af21de453d#diff-1aa980cab8965838a6274f4d9c6fe4b39229d4b8c4cba216ed4e8a7f072efaa1R58
* In this one the legacy name was wrong in the docs. (1)
*
https://github.com/apache/airflow/pull/53722/commits/70d022ebe34e10adb25ce740c4d4d6fcaeb16413
* The variable in the legacy name was different from what was in the
docs. (1)
*
https://github.com/apache/airflow/pull/53722/commits/b3053322f3301f733c0dbc97f48ecd05a22607bd
* 6 missing from the docs.
*
https://github.com/apache/airflow/pull/53722/commits/33d6f5aef4b684dbc6b6e13de7a5e3a79be9d289
* 1 more missing.
*
https://github.com/apache/airflow/pull/53722/commits/1889f45e59f66e4d85d2bac20082ca8148fb22d2
* 1 more missing.
So, it's 8 missing and 2 where there was a mismatch between the docs and the
code. That's the total so far.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
