ashb commented on code in PR #57899:
URL: https://github.com/apache/airflow/pull/57899#discussion_r2496106490
##########
dev/breeze/src/airflow_breeze/params/shell_params.py:
##########
@@ -196,7 +196,7 @@ class ShellParams:
parallel_test_types_list: list[str] = field(default_factory=list)
parallelism: int = 0
platform: str = DOCKER_DEFAULT_PLATFORM
- postgres_version: str = ALLOWED_POSTGRES_VERSIONS[0]
+ postgres_version: str = (DEFAULT_POSTGRES_VERSION,)
Review Comment:
```suggestion
postgres_version: str = DEFAULT_POSTGRES_VERSION
```
##########
dev/breeze/src/airflow_breeze/global_constants.py:
##########
@@ -204,7 +204,6 @@
]
USE_AIRFLOW_MOUNT_SOURCES = [MOUNT_REMOVE, MOUNT_TESTS,
MOUNT_PROVIDERS_AND_TESTS]
-ALLOWED_POSTGRES_VERSIONS = ["13", "14", "15", "16", "17"]
Review Comment:
Therev were two variables "Current" and "Allowed" they both had the same
values.
##########
dev/breeze/tests/test_selective_checks.py:
##########
@@ -1345,7 +1345,7 @@ def test_full_test_needed_when_scripts_changes(files:
tuple[str, ...], expected_
"all-python-versions": ALL_PYTHON_VERSIONS_AS_LIST,
"all-python-versions-list-as-string":
ALL_PYTHON_VERSIONS_AS_STRING,
"mysql-versions": "['8.0', '8.4']",
- "postgres-versions": "['13', '14', '15', '16', '17']",
+ "postgres-versions": "['14', '15', '16', '17', '18]",
Review Comment:
```suggestion
"postgres-versions": "['14', '15', '16', '17', '18']",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
